Support package exports #6125
Support package exports #6125
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hardhatTotal size of the bundle: List of dependencies (sorted by size) |
antico5
force-pushed
the
support-package-exports
branch
from
fd95d70 to
58f0de7
Compare
| await fs.promises.access(packageJsonPath, fs.constants.R_OK); | ||
| return await fs.promises.realpath(packageJsonPath); |
There was a problem hiding this comment.
This should use the utils' fs module
| * @param packageName the name of the package to find | ||
| * @returns the absolute real path (resolved symlinks) of the package.json | ||
| */ | ||
| export async function findPackageJson( |
There was a problem hiding this comment.
We should at at least one or two tests of this
| @@ -1,3 +1,5 @@ | |||
| import type { Exports } from "resolve.exports"; | |||
There was a problem hiding this comment.
We should duplicate this type to avoid re-exporting a dependency type
|
Note to self: Double check that this situation: where and throws that "foo/a.sol" doesn't exist, and not "foo/src/a.sol". |
This PR adds support for package.json#exports for packages that distribute solidity files.
Implementation details:
npm/[email protected]/Foo.solinstead ofnpm/[email protected]/src/Foo.sol, for an import of the kindimport 'mypkg/Foo.sol'. This is arbitraryrequire.resolveto manual lookup using the help ofrequire.resolve.paths, to support packages that don't export their package.jsonresolve.exportspackage. In this case we avoid usingrequire.resolvebecause it may resolve to different packages in the filesystem for a given package name and version.Known issues:
mypkg/TheContract.solresolves tomypkg/src/TheContract.sol. If user doesimport 'mypkg/thecontract.sol', I know that the correct resolved path issrc/TheContract.sol, but I'm not sure how to it back toTheContract.sol. Asking for suggestions on how to approach thisCloses #5992